Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set focus to search field on canned response selection #6502

Closed
wants to merge 4 commits into from

Conversation

JensEB
Copy link
Contributor

@JensEB JensEB commented Mar 29, 2023

Since jQuery is updated to 3.6.x, there is no focus set to the search field into the select2 dropdown field, where you can search your canned responses. So you have to click in it on every ticket resonse, using canned responses.

This pull request will set the focus again...

Since jQuery is updated to 3.6.x, there is no focus set to the search field into the select2 dropdown field, where you can search your canned responses.
So you have to click in it on every ticket resonse, using canned responses.

This pull request will set the focus again...
@JensEB
Copy link
Contributor Author

JensEB commented May 8, 2023

I've changed my commit to add focus to other select2 fields like:

  • timezone field in agent profile
  • timezone field in client profile
  • new ticket by an agent, user search field
  • ticket number search on ticket merge popup

@JediKev
Copy link
Contributor

JediKev commented May 22, 2023

@JensEB

Thank you for the pull request, but this is way overkill imo. The auto-focus issue was actually due to a bug in jQuery 3.6.0 and Select2. jQuery 3.7.0 has been released that includes a fix for the issue. You can retest using the following pull:

Cheers.

@JensEB
Copy link
Contributor Author

JensEB commented May 30, 2023

@JediKev
Yes, I can confirm that your pull request solve the problem.
Cheers

@JensEB JensEB closed this May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants