Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow /quit with a message #395

Merged
merged 9 commits into from
Dec 12, 2022
Merged

Allow /quit with a message #395

merged 9 commits into from
Dec 12, 2022

Conversation

ALEX11BR
Copy link
Contributor

This pull request adds an optional message parameter to the /quit command to be sent to the connected servers as a reason for leaving.

This pull request was tested by using a tiny and a HexChat client, both connected to the same server.

Fixes #365.

Copy link
Owner

@osa1 osa1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Should we add the same parameter to /close as well, to be used in quit message when the closed tab is a server tab?

crates/libtiny_tui/src/tui.rs Outdated Show resolved Hide resolved
@ALEX11BR
Copy link
Contributor Author

added the same parameters to the /close command as well

@osa1 osa1 merged commit 9d46ab6 into osa1:master Dec 12, 2022
@osa1
Copy link
Owner

osa1 commented Dec 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/quit with a message
2 participants