Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

탐지현황 페이지 Pagination #177

Merged
merged 31 commits into from
Oct 14, 2021
Merged

탐지현황 페이지 Pagination #177

merged 31 commits into from
Oct 14, 2021

Conversation

Seo-Faper
Copy link
Collaborator

위협 탐지 현황의 페이지네이션 기능 입니다.

@simonseo simonseo requested a review from cjnghn October 13, 2021 11:12
@simonseo simonseo added functionality New or big enhancement on a functionality visual/ui design labels Oct 13, 2021
@simonseo simonseo added this to In progress in RISKOUT WEB via automation Oct 13, 2021
@simonseo simonseo changed the title Feature/front-pagination 탐지현황 페이지 Pagination Oct 13, 2021
@simonseo simonseo linked an issue Oct 13, 2021 that may be closed by this pull request
@simonseo
Copy link
Collaborator

simonseo commented Oct 13, 2021

@Playff 님께서 컨플릭트 해결 중이십니다.

@cjnghn
Copy link
Contributor

cjnghn commented Oct 13, 2021

@Seo-Faper

conflict 는 다 해결했으나 백엔드 API를 이용해서 테스트는 안해봤습니다. 로컬에서 데이터 가져다 테스트했을 때 많은 페이지가 있는 상태에서 뒷 페이지로 간 뒤 적은 데이터가 나오게 검색을 하면 해당 페이지는 텅 비게 되고, 직접 앞으로 이동해야하는 문제점이 있습니다.

image
image

@cjnghn cjnghn merged commit 85dd601 into develop Oct 14, 2021
RISKOUT WEB automation moved this from In progress to Done Oct 14, 2021
@cjnghn cjnghn deleted the feature/front-pagination branch October 14, 2021 13:11
<TableRow>
<TablePagination
rowsPerPageOptions={[7]}
colSpan={3}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

colSpan={4}여야 하는거 아닌가요?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
functionality New or big enhancement on a functionality visual/ui design
Projects
Development

Successfully merging this pull request may close these issues.

Detection Status Pagination
3 participants