Add partition table handling test #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 16, 2018 14:32
Just in case, we don't want this to be left laying around. Signed-off-by: Josef Bacik <jbacik@fb.com>
Partition tables are hard, add a test to make sure we create/delete them properly. Signed-off-by: Josef Bacik <jbacik@fb.com>
|
(Is there anyway to mention the commit that nbd/002 requires in the commit message or the test? According to #17 (comment) sometimes there's an attempt to list the commit id in case people go using the test suite on older kernels...) |
This is a regression test, list the title of the patches needed for this test to pass. Signed-off-by: Josef Bacik <jbacik@fb.com>
|
Thanks, applied with some fixes/cleanups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some more infrastructure for making sure we don't race with connect/disconnect with NBD for things that require appropriate timing, and then add a test to make sure we handle creating and deleting the partition tables properly. This will fail without the kernel patches that I'm going to send upstream, so keep that in mind.