loop: Add test to setup GPT and ESP on raw disk image #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kawasaki
requested changes
Jun 10, 2022
There was a problem hiding this comment.
Hi @michael-schaller
Thank you for this PR. The code logic looks good. Let me make a few comments on other things.
- Apache license is noted in the file header comment. However, GPL3+ is the license for blktests (some files have GPL2+). To keep license of blktests simple, I wish to see GPL3+ for this new test case also.
- The commit title is rather lengthy. The additional note in parenthesis (regression ...) can be removed, I think.
- The line of commit message is too long. I wish to see 72 characters each in the commit message lines.
Hope these requests are reasonable for you.
michael-schaller
changed the title
|
Done. Please take another look. |
|
@michael-schaller Thanks for the license change! However, the 2nd commit for license change does not have your Signed-off-by tag, which all blktests commits have. Could you add the tag? Also, single commit is the better record than the two commits. Could you squash the two commits into one and force push to your git branch? Or if it takes too much time for you, please let me know. I can do that squash work. |
Add test for setting up a raw disk image with a GPT and ESP.
This is a regression test for commit b9684a71fca7
("block, loop: support partitions without scanning").
Signed-off-by: Michael Schaller <misch@google.com>
|
Done. Please take another look. |
|
@michael-schaller Thanks for the updates. Applied to the master branch. |
|
Thanks. 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test for setting up a raw disk image with a GPT and ESP.
This is a regression test for commit b9684a71fca7
("block, loop: support partitions without scanning").
Signed-off-by: Michael Schaller misch@google.com