Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessibility (public, private, protected) to drgn.TypeMember #83

Open
Tracked by #328
osandov opened this issue Jan 10, 2021 · 1 comment
Open
Tracked by #328

Add accessibility (public, private, protected) to drgn.TypeMember #83

osandov opened this issue Jan 10, 2021 · 1 comment
Assignees
@prozak
Labels
C++ Support for C++ debugging enhancement New feature or request

Comments

@osandov
Copy link
Owner

osandov commented Jan 10, 2021

We need to:

  1. Add the accessibility to struct drgn_type_member and drgn.TypeMember (probably as an enum).
  2. Include it when pretty printing a type.
  3. Parse it from DWARF.

From section 5.7.6 in the DWARF 5 spec:

A data member entry may have a DW_AT_accessibility attribute. If no accessibility attribute is present, private access is assumed for an member of a class and public access is assumed for an member of a structure, union, or interface.

Section 2.8 defines the accessibility codes (DW_ACCESS_public, DW_ACCESS_private, and DW_ACCESS_protected).
@osandov osandov added enhancement New feature or request C++ Support for C++ debugging labels Jan 10, 2021
prozak added a commit to prozak/drgn that referenced this issue Feb 15, 2022
@prozak
Enable prog.type to work with classes
0a81e84 
Also added end to end CPP tests

This is a prerequisite to osandov#83

Signed-off-by: prozak <nickolay.lysenko@gmail.com>
@prozak prozak mentioned this issue Feb 15, 2022
Merged
prozak added a commit to prozak/drgn that referenced this issue Feb 15, 2022
@prozak
Enable prog.type to work with classes
51ff19e 
Also added end to end CPP tests

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 15, 2022
@prozak
Enable prog.type to work with classes
8f8fc4a 
Also added end to end CPP tests

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 18, 2022
@prozak
Enable prog.type to work with classes
10dd616 
Also added test for CPP class type

This is a prerequisite to osandov#83
prozak added a commit to prozak/drgn that referenced this issue Feb 18, 2022
@prozak
Enable prog.type to work with classes
49eb691 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 18, 2022
@prozak
Enable prog.type to work with classes
beb99eb 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 18, 2022
@prozak
Enable prog.type to work with classes
8485de8 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 19, 2022
@prozak
Enable prog.type to work with classes
bdff3eb 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 19, 2022
@prozak
Enable prog.type to work with classes
ef07304 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 19, 2022
@prozak
Enable prog.type to work with classes
4637ea0 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 22, 2022
@prozak
Enable prog.type to work with classes
7ddef17 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
prozak added a commit to prozak/drgn that referenced this issue Feb 22, 2022
@prozak
Enable prog.type to work with classes
dd147d0 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
osandov pushed a commit to prozak/drgn that referenced this issue Feb 22, 2022
@prozak @osandov
Enable prog.type to work with classes
24836da 
Also added test for CPP class type

This is a prerequisite to osandov#83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
osandov pushed a commit that referenced this issue Feb 22, 2022
@prozak @osandov
Enable prog.type to work with classes
e8dada0 
Also added test for CPP class type

This is a prerequisite to #83

Signed-off-by: mykolal <nickolay.lysenko@gmail.com>
@prozak
Copy link
Contributor

prozak commented Feb 22, 2022

@osandov I will take this one if you do not mind

@osandov osandov mentioned this issue Jul 5, 2023
Open
25 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prozak prozak

Labels
C++ Support for C++ debugging enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prozak @osandov