C unit tests #392
Merged
C unit tests #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The C standard treats an empty variable argument list as a single, empty argument, so PP_NARGS() currently expands to 1. But this is surprising, especially for PP_OVERLOAD(). Use the , ##__VA_ARGS__ GNU C extension to make PP_NARGS() expand to 0 instead. (We could also use __VA_OPT__(,) to achieve the same thing. It has the advantage of being standardized for C23, but the huge disadvantage that it's only available on relatively recent versions of GCC and Clang.) Also check that the extension is supported in configure. Signed-off-by: Omar Sandoval <osandov@osandov.com>
Some upcoming tests will use this for generating test cases. Signed-off-by: Omar Sandoval <osandov@osandov.com>
So far we've been getting away with only unit testing through Python. However, there's plenty of (existing and upcoming) internal code that would be nice to unit test directly in C. For a framework, I opted for check (https://libcheck.github.io/check/) because it is minimal, mature, and available on all major distros. Add the autotools scaffolding, including a copy of the checkmk script from check 0.15.2 since RHEL and CentOS don't package it. We check the dependencies at configure time but only fail if they're not available at `make check` time. Also wire up `setup.py test` to run `make check`. Signed-off-by: Omar Sandoval <osandov@osandov.com>
To try out our new testing framework, move some simple Python unit tests for the internal lexer API to C unit tests. Signed-off-by: Omar Sandoval <osandov@osandov.com>
This allows us to get rid of a bunch of exports and ctypes wrappers. Signed-off-by: Omar Sandoval <osandov@osandov.com>
Signed-off-by: Omar Sandoval <osandov@osandov.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add scaffolding for writing unit tests in C using check and translate most of the tests using the
libdrgn/python/test.chack. Theserialize_bits()/deserialize_bits()tests still need to be translated.I'm opening this as a PR mainly to get a Packit run.