Add more tests to improve code coverage

osantana · Jan 31, 2019 · ee8673e · ee8673e
1 parent bf02c30
commit ee8673e
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 2 deletions.
diff --git a/prettyconf/loaders.py b/prettyconf/loaders.py
@@ -243,7 +243,6 @@ def __getitem__(self, item):
 
 
 class RecursiveSearch(AbstractConfigurationLoader):
-
     def __init__(self, starting_path, filetypes=(('.env', EnvFile), (('*.ini', '*.cfg',), IniFile),), root_path="/"):
         """
         :param str starting_path: The path to begin looking for configuration files.

diff --git a/tests/test_cfgfile.py b/tests/test_cfgfile.py
@@ -8,6 +8,11 @@ def setUp(self):
         super(IniFileTestCase, self).setUp()
         self.inifile = self.test_files_path + "/config.ini"
 
+    def test_basic_config_object(self):
+        config = IniFile(self.inifile)
+
+        self.assertEqual(repr(config), 'IniFile("{}")'.format(self.inifile))
+
     def test_fail_invalid_settings_file(self):
         with self.assertRaises(InvalidConfigurationFile):
             return IniFile(self.test_files_path + "/invalid_section.ini")['some_value']
@@ -58,3 +63,12 @@ def formatter(x):
 
         self.assertIn("VAR", config)
         self.assertEqual("test", config["VAR"])
+
+    def test_fail_missing_envfile_contains(self):
+        config = IniFile("does-not-exist.ini")
+        self.assertNotIn('error', config)
+
+    def test_fail_missing_envfile_get_item(self):
+        config = IniFile("does-not-exist.ini")
+        with self.assertRaises(KeyError):
+            return config['error']
diff --git a/tests/test_commandline.py b/tests/test_commandline.py
@@ -18,7 +18,6 @@ def test_parse_args():
 
 
 class CommandLineTestCase(BaseTestCase):
-
     def setUp(self):
         super(CommandLineTestCase, self).setUp()
         parser = parser_factory()
@@ -47,3 +46,6 @@ def test_args():
         config = CommandLine(parser=parser)
         self.assertEquals(config['var'], 'bar')
         self.assertEquals(config['var2'], 'bar2')
+
+    def test_contains_missing_keys(self):
+        self.assertNotIn('var3', self.config)
diff --git a/tests/test_envfile.py b/tests/test_envfile.py
@@ -9,6 +9,11 @@ def setUp(self):
         super(EnvFileTestCase, self).setUp()
         self.envfile = os.path.join(self.test_files_path, "envfile")
 
+    def test_basic_config_object(self):
+        config = EnvFile(self.envfile)
+
+        self.assertEqual(repr(config), 'EnvFile("{}")'.format(self.envfile))
+
     def test_config_file_parsing(self):
         config = EnvFile(self.envfile)
 
@@ -49,3 +54,12 @@ def formatter(x):
 
         self.assertIn("VAR", config)
         self.assertEqual("test", config["VAR"])
+
+    def test_fail_missing_envfile_contains(self):
+        config = EnvFile("does-not-exist.env")
+        self.assertNotIn('error', config)
+
+    def test_fail_missing_envfile_get_item(self):
+        config = EnvFile("does-not-exist.env")
+        with self.assertRaises(KeyError):
+            return config['error']