Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparing merge of PR #20 #21

Merged
merged 48 commits into from
Feb 1, 2019
Merged

Preparing merge of PR #20 #21

merged 48 commits into from
Feb 1, 2019

Conversation

osantana
Copy link
Owner

@osantana osantana commented Jan 31, 2019

Closes #18

@coveralls
Copy link

coveralls commented Jan 31, 2019

Coverage Status

Coverage decreased (-0.7%) to 99.32% when pulling f56671f on pr/20 into 3ec45b6 on master.

@osantana osantana mentioned this pull request Jan 31, 2019
4 tasks
.travis.yml Show resolved Hide resolved
@hernantz
Copy link
Contributor

@osantana Looks good, I forgot to add __repr__() for the other loaders, I think we should add them for consistency.

@hernantz
Copy link
Contributor

Throwing this out there, repr for Configuration() could be:

    def __repr__(self):
        return 'Configuration(loaders=[{}])'.format(', '.join([repr(l) for l in self.loaders]))

which results in:

>>> from prettyconf import config
>>> config
Configuration(loaders=[Environment(), RecursiveSearch(starting_path="/home/hernantz/devel/prettyconf/prettyconf", root_path="/")])

@osantana
Copy link
Owner Author

Let's go? :)

@hernantz
Copy link
Contributor

It's a go on my end :)

@osantana osantana merged commit 3eb3e5d into master Feb 1, 2019
@osantana osantana deleted the pr/20 branch February 1, 2019 01:37
@osantana
Copy link
Owner Author

osantana commented Feb 1, 2019

Released! Thank you!
https://pypi.org/project/prettyconf/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants