Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memory leak when graphical editor fails to load diagram #1389

Closed
philip-alldredge opened this issue Jul 19, 2018 · 0 comments
Closed

Memory leak when graphical editor fails to load diagram #1389

philip-alldredge opened this issue Jul 19, 2018 · 0 comments
Assignees
@philip-alldredge
Labels
category:bug ge
Milestone
2.3.5

Comments

@philip-alldredge
Copy link
Collaborator

When opening a diagram which does not have a valid context, a dialog appears to relink the context. If the Cancel is pressed an error is displayed. However, when that editor is closed, the AgeDiagramEditor object is still retained in memory. Based on the initial examination, the eclipse context created by the feature provider does not appear to be disposed. Check why the feature provider would not be disposed and fix.
@philip-alldredge philip-alldredge added this to the 2.3.5 milestone Jul 19, 2018
@philip-alldredge philip-alldredge self-assigned this Jul 19, 2018
philip-alldredge added a commit that referenced this issue Jul 31, 2018
@philip-alldredge
Perform proper cleanup when initialization fails.
e6ece0e 
Perform proper cleanup when initialization fails. Ensure feature
provider and thus the eclipse context is disposed. Closes #1389.
@ghost ghost added the in progress label Jul 31, 2018
@philip-alldredge philip-alldredge mentioned this issue Jul 31, 2018
Merged
@ghost ghost added review and removed in progress labels Jul 31, 2018
philip-alldredge added a commit that referenced this issue Aug 2, 2018
@philip-alldredge
Perform proper cleanup when initialization fails. (#1422)
d0dc1a7 
Perform proper cleanup when initialization fails. Ensure feature
provider and thus the eclipse context is disposed. Closes #1389.
@ghost ghost removed the review label Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philip-alldredge philip-alldredge

Labels
category:bug ge
Projects
None yet
Milestone
2.3.5
Development

No branches or pull requests
1 participant
@philip-alldredge