New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialized reference to ErrorTypes incorrectly qualified #1399

Closed
joeseibel opened this Issue Jul 24, 2018 · 0 comments

Comments

Projects
None yet
2 participants
@joeseibel
Contributor

joeseibel commented Jul 24, 2018

When serializing a reference to an ErrorTypes that does not have a corresponding INode, the reference may end up being qualified with an error library where the ErrorTypes is not defined, but which extends the correct error library.

For example, assume that the error library A_Lib extends from ErrorLibrary. Serializing a reference to the type AboveRange will result in A_Lib::AboveRange. This is still valid since A_Lib extends from ErrorLibrary, but it is more desirable to serialize the reference to ErrorLibrary::AboveRange.

@joeseibel joeseibel self-assigned this Jul 24, 2018

@wafflebot wafflebot bot added the in progress label Jul 24, 2018

@wafflebot wafflebot bot added review and removed in progress labels Jul 24, 2018

@lwrage lwrage closed this in #1400 Jul 25, 2018

@wafflebot wafflebot bot removed the review label Jul 25, 2018

@lwrage lwrage added this to the 2.3.5 milestone Jul 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment