Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detection reporting port #2256

Merged
merged 5 commits into from Apr 2, 2020
Merged

Detection reporting port #2256

merged 5 commits into from Apr 2, 2020

Conversation

joeseibel
Copy link
Contributor

Fixes #2128.

@joeseibel
Fixed warnings.
35a04ed
@joeseibel
Split scope_ErrorDetection_detectionReportingPort into two methods.
4abb57e 
By having one method for ComponentImplements and another for
Classifiers, an instanceof check is no longer required.
@joeseibel
Allow ErrorDetections to refer to ports in feature groups.
0946ba5
reteprelief
reteprelief approved these changes Mar 30, 2020
View reviewed changes
Copy link
Contributor

@reteprelief reteprelief left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@lwrage lwrage merged commit 39504e3 into master Apr 2, 2020
@lwrage lwrage deleted the 2128_detection_reporting_port branch May 5, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reteprelief reteprelief reteprelief approved these changes

@jjhugues jjhugues jjhugues approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EMV2: error_detection_effect not allow port in feature group
4 participants
@joeseibel @reteprelief @jjhugues @lwrage