Skip to content

Commit

Permalink
wizard: don't show the form as a modal
Browse files Browse the repository at this point in the history
When the user clicks on the "create an image" button, the image wizard
shows up replacing the landing page. This allows to keep the quickstart
guides to the right of the wizard while the user is interacting with it.
  • Loading branch information
lavocatt committed Sep 19, 2023
1 parent 1bb7519 commit 60d2122
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 9 deletions.
2 changes: 1 addition & 1 deletion src/Components/CreateImageWizard/CreateImageWizard.js
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ const CreateImageWizard = () => {
name: 'image-builder-wizard',
className: 'imageBuilder',
isDynamic: true,
inModal: true,
inModal: false,
onKeyDown: (e) => {
handleKeyDown(e, handleClose);
},
Expand Down
7 changes: 7 additions & 0 deletions src/Components/CreateImageWizard/CreateImageWizard.scss
Original file line number Diff line number Diff line change
Expand Up @@ -59,3 +59,10 @@ ul.pf-m-plain {
padding-left: 0;
margin-left: 0;
}

// [2023-09] Wizard height should not be limited see
// https://github.com/data-driven-forms/react-forms/issues/1402
.pf-c-wizard__main {
overflow-x: unset;
overflow-y: unset;
}
16 changes: 8 additions & 8 deletions src/Router.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,17 +24,17 @@ export const Router = () => {
</Suspense>
}
>
<Route
path="imagewizard/:composeId?"
element={
<Suspense>
<CreateImageWizard />
</Suspense>
}
/>
<Route path="share/:composeId" element={<ShareImageModal />} />
</Route>

<Route
path="imagewizard/:composeId?"
element={
<Suspense>
<CreateImageWizard />
</Suspense>
}
/>
{edgeParityFlag && (
<Route
path={`/${manageEdgeImagesUrlName}/:imageId`}
Expand Down

0 comments on commit 60d2122

Please sign in to comment.