Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repositories state refactor #1924

Open
lucasgarfield opened this issue Apr 11, 2024 · 1 comment
Open

Repositories state refactor #1924

lucasgarfield opened this issue Apr 11, 2024 · 1 comment
Assignees

Comments

@lucasgarfield
Copy link
Collaborator

I'm getting a little worried the Wizard's state is becoming too confusing here - we've got a Payload Repositories field, a Custom Repositories field, and now a Recommended Repositories field.

I think that we should collapse these into a single field, SelectedRepositories, and then we can generate the payload and custom repositories fields when we generate the request.

This should make it much easier to ensure that bugs like this, where adding a new repo via the Proactive Assistance modal does not cause the repo to become selected on the repositories step, do not occur:
image

@regexowl
Copy link
Collaborator

Fair enough, I'll gladly take this one. Originally the step was just migrated to V2 with minimal refactoring, but as I started working on repo recommendations I've noticed a few things I'd like to do differently.

Merging all the repos into one field in the state sounds good, the recommended ones can be differentiated by a flag. This way we shouldn't lose any functionality/detail needed to render things properly.

@regexowl regexowl self-assigned this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants