Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1/api: Image name transposition from Blueprint name (HMS-3801) #1093

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ezr-ondrej
Copy link
Collaborator

@ezr-ondrej ezr-ondrej commented Mar 21, 2024

On composing Blueprint, transpose its name to image name,
that's machine friendly, unlike Blueprint name that's human readable.

Refs HMS-3801

Follow-up for #1089

On composing Blueprint, transpose its name to image name,
that's machine friendly, unlike Blueprint name that's human readable.

Refs HMS-3801
Copy link

github-actions bot commented May 9, 2024

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 9, 2024
@lzap
Copy link
Collaborator

lzap commented May 14, 2024

Not a fan of ignoring nations who do not use latin characters, Go UTF implementation is really good and there are simple ways now to filter out non-pritable characters while keeping the others. If alphanum is a requirement by composer, maybe we can talk about lifting this requirement. If that cannot be achieved, well, this is the way to go then.

@github-actions github-actions bot removed the Stale label May 15, 2024
@ezr-ondrej
Copy link
Collaborator Author

If that cannot be achieved, well, this is the way to go then.

I'm actually not sure where there is no support for UTF, I think it was an Azure image name. But I agree we might just fix it per the offender and not everywhere 🤔

Copy link

This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants