server: un-disable gosec #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chloenayon
force-pushed
the
undisablegosec
branch
from
310ac27
to
27917b9
Compare
croissanne
reviewed
Mar 18, 2021
internal/server/distribution.go
Outdated
| var d DistributionFile | ||
| err = json.NewDecoder(f).Decode(&d) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| err = f.Close() |
There was a problem hiding this comment.
Hmm, if the decoding errors out the file will never be closed now. I think what's best is to change the defer function a little, see securego/gosec#512 (comment) ; wdyt?
There was a problem hiding this comment.
Yes, that makes sense - thanks for pointing that out! I'll make changes
Previously contained gosec overrides for G304 and G307, amend code so that the overrides can be safely removed without triggering gosec violations. Clean filepaths before calling os.Open and remove instances of deferring f.Close so that errors can be caught before return.
chloenayon
force-pushed
the
undisablegosec
branch
from
27917b9
to
30293d1
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously contained gosec overrides for G304 and G307, amend code so that the
overrides can be safely removed without triggering gosec violations. Clean
filepaths before calling os.Open and remove instances of deferring f.Close
so that errors can be caught before return.