Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RHC credentials from the system after registration (HMS-3814) #627

Merged
merged 9 commits into from
Apr 25, 2024
Merged

Remove RHC credentials from the system after registration (HMS-3814) #627

merged 9 commits into from
Apr 25, 2024

Commits on Apr 23, 2024

  1. cmd: enable all distro.ImageOptions on build configs 

    Add the distro.ImageOptions struct to the build configs used by the
build and gen-manifests commands.
Annotate it with json tags to control the serialised keys.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    94671a8 View commit details
    Browse the repository at this point in the history

  2. test: update all configs to new structure 

    Move "ostree" under "options".
Update test scripts that read or set configs to follow the new
structure.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    a07e33c View commit details
    Browse the repository at this point in the history

  3. osbuild: NewSystemdUnitCreateStageOptions -> NewSystemdUnitCreateStage 

    The function was incorrectly named New...StageOptions but it was
creating a Stage.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    06c28bb View commit details
    Browse the repository at this point in the history

  4. osbuild: update the systemd.unit.create stage 

    Update the options of the org.osbuild.systemd.unit.create stage with the
new After option.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    21bce9b View commit details
    Browse the repository at this point in the history

  5. manifest: replace subscription first-boot stage with a custom service 

    Replace the org.osbuild.first-boot stage with an
org.osbuild.systemd.unit.create stage that runs the same commands.  Add
the 'rm' command that gets added by the first-boot stage, but put it at
the end.

Also, unlike the service created by osbuild's first-boot stage, our
current service also includes an install section.

The file name and service description are changed to describe the
purpose of the service.

Otherwise the two are functionally identical.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    e583412 View commit details
    Browse the repository at this point in the history

  6. manifest: inject env file with org and activation key 

    Create the file in /etc that will act as both the EnvironmentFile and
the ConditionPathExists for the service.  This file includes the org ID
and activation key.  When the service runs, the file is removed so that
the service doesn't run again (only runs on first boot) and the org ID
and key are removed from the system.

Rename the file to osbuild-subscription-register.env to make its purpose
clearer.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    c26654b View commit details
    Browse the repository at this point in the history

  7. manifest: update subscription stage tests 

    Update subscription stage tests to match the commands run by the
systemd.unit.create stage (was first-boot).
Prepend the rm command to all command lists passed to the
CheckSystemdStageOptions() function and verify the ConditionPathExists
value and the file being rm-ed are the same.
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    6987b35 View commit details
    Browse the repository at this point in the history

  8. manifest: use long args for rhc connect

    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    1928c88 View commit details
    Browse the repository at this point in the history

  9. Schutzfile: update osbuild dependency 

    Update osbuild commit ID to include
osbuild/osbuild#1741
    @achilleas-k
    achilleas-k committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    68c276b View commit details
    Browse the repository at this point in the history