manifest: add new PayloadRemoveSignatures to isoinstaller
#659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for the new `remove-signatures` option in the osbuild skopeo stage. See: osbuild/osbuild#1752 osbuild/osbuild#1763
This allows to parameterize the skopeo copy stage to remove the signatures during the copy.
This will be passed down to the skopeo stage.
mvo5
force-pushed
the
bootc-iso-remove-signatures
branch
from
531ae7f
to
67329e8
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to parameterize the skopeo copy stage to remove the signatures during the copy and will be used from
bib.Note that this is a minimal version, I think the API needs to be changed but there is already main...ondrejbudai:images:dir in the works and I do not want to create unnecessary conflicts here.
See also
osbuild/osbuild#1752
osbuild/osbuild#1763
This will then be used by bib in e.g. https://github.com/osbuild/bootc-image-builder/compare/main...mvo5:use-remove-sig?expand=1