New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
schutzbot: enable F33 testing #1014
Conversation
567aa2a
to
965d12e
Compare
FYI: F33 snapshots are now available. First one is:
I will make another one the coming weekend. You can enumerate the snapshots here:
If you need another snapshot earlier than next Monday, lemme know! |
d18d623
to
fcdf2cf
Compare
0f1a6f5
to
4f88274
Compare
The downloaded image may not fit inside tmpfs, especially when testing on a constrained VM. This commit makes the test script use a different temporary directory while handling the possibly big image.
Let's use the same repository as for Fedora 32, it proved to be very stable.
If the ostree test was run on an unsupported distro, it failed but with a very weird error message. This commit makes the test fail fast and with a nice message.
This commit does several things: 1) Changes the Fedora 33 repos in the test case generator from development to release ones. 2) Fixes format-request-map.json so we can generate fedora-iot-commit "images". 3) Regenerates all the cases.
osbuild-composer now has support, let's fire up more VMs! Currently, F33 beta is used in both AWS and PSI.
4f88274
to
6be6ba3
Compare
After 42 days, this is finally finished and green! This is just the tip of the iceberg, many stuff needed to properly support Fedora 33 testing was merged earlier:
This PR does basically 3 things:
But there's one more thing! Qemu tests downloaded the image to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't checked the test cases properly, they are rather long, but otherwise this looks very good!
} | ||
post { | ||
always { | ||
preserve_logs('fedora33-image') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preserve_logs('fedora33-image') | |
preserve_logs('fedora33-image') | |
sh ( | |
label: "Run cloud cleaner just in case something failed", | |
script: "schutzbot/run_cloud_cleaner.sh" | |
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, thanks! I added those lines before the cloud cleaner was introduced.
# Current $PWD is inside /tmp, there may not be enough space for an image. | ||
# Let's use a bigger temporary directory for this operation. | ||
BIG_TEMP_DIR=/var/lib/osbuild-composer-tests | ||
sudo rm -rf "${BIG_TEMP_DIR}" || true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the || true
part? Shouldn't it be fine with non-existing or empty directory because of -f
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, right, didn't know about this -f
's behavior.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My previous comments are not blockers and CI is all green. Thank you @ondrejbudai !
Update as of 2020-11-11
This is now done, see today's comment.
Progress as of 2020-10-02
Done so far
kolo/xmlrpc
was rebased in F33 and has a slightly different API. This PR ships a somewhat ugly workaround, see individual commits for more info.s3cmd
used inmockbuild.sh
does not work on F33 because of changes in Python 3.9. I've sent a PR upstream and a bug downstream. This PR applies the same patch tos3cmd
as is in the upstream PR.openssl
installed so I have to install it manually so we can generate TLS keys for remote worker/cloud/koji API.Needs work
test/image-tests/ostree.sh: line 167: IMAGE_TYPE: unbound variable
- no idea, I haven't had time to investigate yet.