Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for push to VMWare #1169

Merged
merged 6 commits into from Feb 16, 2021
Merged

Add support for push to VMWare #1169

merged 6 commits into from Feb 16, 2021

Conversation

jmikovic
Copy link
Contributor

@jmikovic jmikovic commented Jan 20, 2021 •
edited

Add upload target for VMWare images to weldr API to allow users to push them directly to their vSphere instance without the need to download and push the image manually.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change

ondrejbudai
ondrejbudai reviewed Jan 21, 2021
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! :-)

Do you plan to add an integration test for this feature?

Also, you need to run tools/prepare-source.sh and force-push the changes, the source check is currently failing.

teg
teg requested changes Jan 24, 2021
View reviewed changes
Copy link
Member

@teg teg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very, very nice! I had some minor comments about he API, but over all this is looking like a great start.

cmd/osbuild-worker/jobimpl-osbuild.go Outdated Show resolved Hide resolved
internal/target/vmware_target.go Show resolved Hide resolved
internal/upload/vmware/vmware.go Outdated Show resolved Hide resolved
@jmikovic jmikovic marked this pull request as draft January 25, 2021 10:46
@jmikovic jmikovic force-pushed the vmware-upload branch 2 times, most recently from bf4fd73 to 2ea66ce Compare January 26, 2021 09:30
@jmikovic jmikovic marked this pull request as ready for review January 26, 2021 10:57
teg
teg requested changes Jan 27, 2021
View reviewed changes
Copy link
Member

@teg teg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great! Only thing I think we need before merging is an integration test. Something similarly to test/cases/aws.sh.

ondrejbudai
ondrejbudai reviewed Jan 27, 2021
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Two super-minor comments inline.

internal/upload/vmware/vmware.go Show resolved Hide resolved
cmd/osbuild-worker/jobimpl-osbuild.go Outdated Show resolved Hide resolved
@jmikovic jmikovic force-pushed the vmware-upload branch 3 times, most recently from 233bc33 to 8104110 Compare February 9, 2021 07:48
@jmikovic jmikovic requested a review from teg February 9, 2021 07:51
@jmikovic jmikovic force-pushed the vmware-upload branch 2 times, most recently from 7debb4a to a1f88e9 Compare February 9, 2021 14:16
teg
teg previously approved these changes Feb 10, 2021
View reviewed changes
Copy link
Member

@teg teg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests @jmikovic! This looks great!

ondrejbudai
ondrejbudai reviewed Feb 11, 2021
View reviewed changes
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, awesome work Jozef! :)

@jmikovic jmikovic force-pushed the vmware-upload branch 10 times, most recently from 29f0115 to 33ec3d6 Compare February 16, 2021 09:40
@jmikovic
osbuild-worker: add target for upload to vmware
e6c3d60 
New upload target for VMWare, similar to the ones for AWS and Azure,
allowing users to set credentials for their vSphere instance.
Commit also includes function that performs the actual upload.
@jmikovic
weldr: add vmware upload target to api
8fd6c51 
Extend Weldr API to allow user to specify option to upload built image to VMWare,
makes use of previously define upload target.
@jmikovic
osbuild-worker: ensure that uploaded vmdk image has the user specifie…
2793f21 
…d name

VMDK image has default name 'disk.vmdk' and there is no option to change the name when uploading to vSphere,
so I'm using symlink so that uploaded image has the name user specified instead of the default one.
@jmikovic
upload/vmware: document uploadImage function
cc86048
@jmikovic
docs/news: describe new upload target
68561a4
@jmikovic
test: Add integration test for VMWare upload
947d250
@jmikovic
Copy link
Contributor Author

@teg @ondrejbudai please re-review

test is failing on openstack test - not related to this PR

@teg
Copy link
Member

teg commented Feb 16, 2021

Thanks @jmikovic! Will do :)

teg
teg approved these changes Feb 16, 2021
View reviewed changes
Copy link
Member

@teg teg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing to see this land! Thanks @jmikovic!

@teg
Copy link
Member

teg commented Feb 16, 2021

Error in image tests for f32 must be unrelated, as the image definitions did not change. Merging.

@teg teg merged commit 5a9d2fe into osbuild:main Feb 16, 2021
@jmikovic jmikovic deleted the vmware-upload branch February 17, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejbudai ondrejbudai ondrejbudai left review comments

@teg teg teg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jmikovic @teg @ondrejbudai