Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloudapi/v2: ensure only one image per a compose in the API spec #1912

Merged
merged 3 commits into from
Oct 13, 2021
Merged

cloudapi/v2: ensure only one image per a compose in the API spec #1912

merged 3 commits into from
Oct 13, 2021

Conversation

ondrejbudai
Copy link
Member

@ondrejbudai ondrejbudai commented Oct 13, 2021 •
edited

We've never had the ability to build multiple images per a compose, this
commit thus rips out support for this on the API level:

image_requests is now image_request and it accepts only one ImageRequest
object instead of an array of them.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@ondrejbudai
cloudapi/v2: move multi-image compose check to the beginning
abcc21f 
Signed-off-by: Ondřej Budai <ondrej@budai.cz>
@ondrejbudai
cloudapi/v2: clean up targets
27b4e60 
tbh, I don't fully understand why we wrote the code in this way.

Not a functional change.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
@ondrejbudai
cloudapi/v2: ensure only one image per a compose in the API spec
aa41935 
We've never had the ability to build multiple images per a compose, this
commit thus rips out support for this on the API level:

image_requests is now image_request and it accepts only one ImageRequest
object instead of an array of them.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
croissanne
croissanne approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍 Nice to have that entire block un-indented.

@croissanne croissanne merged commit 7760ca1 into osbuild:main Oct 13, 2021
@ondrejbudai ondrejbudai deleted the image-request branch February 21, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croissanne croissanne croissanne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ondrejbudai @croissanne