[9.1] distro/rhel9: edge images default to LVM #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change partition tables on edgeBase images to use 'LVM partitioning'. We need to ensure that LVM stages are done before LUKS stages (e.g. remove-key) or the pipelines will break (we cannot open a device when its password has changed). Add relevant tests on device_test.go plus a new test partition table on common_test.go Signed-off-by: Antonio Murdaca <runcom@linux.com>
Signed-off-by: Antonio Murdaca <runcom@linux.com>
In podman v4.0.0 the default network backend was switched from cni to netavark. However, podman will choose cni if there are already containers, images, or cni networks preset on a system [1]. Starting with podman v4.2.0, containernetworking-plugins is no longer a hard requirement for podman. So when an edge commit is built with an embedded container, podman v4.2.0+ will choose the cni network and fail with an error because the plugin isn't installed. Adding the package explicitly alongside podman to avoid this issue with future RHEL 9.1 edge builds when they include containers. This change does not affect test manifests. The package is already included in manifests as a dependency of podman < v4.2.0. See rhbz#2123210 [1] https://github.com/containers/common/blob/a083f790abf21048518f2d66b7e01370cc055790/pkg/config/containers.conf#L275-L278
Since api.ocp.ci.centos.org is going away: https://lists.centos.org/pipermail/ci-users/2022-June/004547.html. After discussion, OCP4 test will be removed here, but RHEL for Edge downstream test will keep OCP4 case
runcom
force-pushed
the
edge-lvm-91
branch
2 times, most recently
from
a1712b1
to
1d9c15b
Compare
Signed-off-by: Antonio Murdaca <runcom@linux.com>
Distro version branches aren't synced to GitLab, so we will need to fetch them from GitHub directly. This is required for any PR made against any branch other than main.
schutzbot
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
ondrejbudai
reviewed
Sep 15, 2022
Due to https://bugzilla.redhat.com/show_bug.cgi?id=2124735 and https://bugzilla.redhat.com/show_bug.cgi?id=2108646 we can't really go ahead with cs9 so disable it and investigate further afterwards. Signed-off-by: Antonio Murdaca <runcom@linux.com>
schutzbot
reviewed
Sep 15, 2022
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
instead of manually updating CIV version every once in a while. Get always the latest version. In CIV CI, this test runs before any change can be introduced into the container image, so no unexpedted errors should come from the CIV side.
We were using `latest` as tag, this can be dangerous as it's the default tag, an anyone can accidentally update it. Using `prod` is safer. Also use dev container image if the test script is running in CIV CI.
schutzbot
reviewed
Sep 15, 2022
There was a problem hiding this comment.
Manifest-diff job [0] as manifests.diff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #2861
Change partition tables on edgeBase images to use 'LVM partitioning'.
We need to ensure that LVM stages are done before LUKS stages (e.g. remove-key) or the pipelines will break (we cannot open a device when its password has changed).
This PR requires changes on coreos-installer-dracut/dracut/scripts/coreos-installer-growfs(coreos/coreos-installer-dracut#9) required by rhel90-edge images to account for the change from traditional partitioning to LVM, otherwise the image will boot on an emergency shell and will need a manual reboot.
This pull request includes: