Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iscsi support to the oci image type #3264

Closed
wants to merge 5 commits into from

Conversation

ondrejbudai
Copy link
Member

Bare metal instances can access block volumes only using iSCSI. Therefore, we need to install iscsi-initiator-utils and pass the right kernel options in order to make boot from iSCSI-attached volume possible.

This pull request includes:

  • adequate testing for the new functionality or fixed issue
  • adequate documentation informing people about the change such as

@ondrejbudai ondrejbudai added the WIP+test Work in progress but run Gitlab CI. label Feb 2, 2023
@teg
Copy link
Member

teg commented Feb 2, 2023

For the final version, I think this should be part of the Platform abstraction.

Bare metal instances can access block volumes only using iSCSI. Therefore,
we need to install iscsi-initiator-utils and pass the right kernel options
in order to make boot from iSCSI-attached volume possible.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Bare metal instances can access block volumes only using iSCSI. Therefore,
we need to install iscsi-initiator-utils and pass the right kernel options
in order to make boot from iSCSI-attached volume possible.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Bare metal instances can access block volumes only using iSCSI. Therefore,
we need to install iscsi-initiator-utils and pass the right kernel options
in order to make boot from iSCSI-attached volume possible.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
oci image definitions were changed, let's regen them.

Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Copy link
Collaborator

@schutzbot schutzbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This PR introduces changes in at least one manifest (when comparing PR HEAD 29db29f with the main merge-base 3cdfa9d). Please review the changes. The changes can be found in the artifacts of the Manifest-diff job [0] as manifests.diff.

[0] https://gitlab.com/redhat/services/products/image-builder/ci/osbuild-composer/-/jobs/3735671519/artifacts/browse

@ondrejbudai
Copy link
Member Author

We don't have enough resources to get this finished anytime soon. Also, everything in this PR can be achieved just by applying the right customizations. Here's a quick guide I put together:

  1. Install image builder (needs a subscribed machine):
dnf install -y osbuild-composer composer-cli
  1. Enable the image building service
systemctl enable --now osbuild-composer.socket
  1. Create a file named blueprint.toml with the following content:
name = "oci-baremetal"

[[packages]]
name = "iscsi-initiator-utils"

[customizations.kernel]
append = "rd.iscsi.ibft=1 rd.iscsi.firmware=1 rd.iscsi.param=node.session.timeo.replacement_timeout=6000"
  1. Push the blueprint file into image builder
sudo composer-cli blueprints push blueprint.toml
  1. Start an image build
sudo composer-cli compose start oci-baremetal qcow2
  1. Wait for it to be FINISHED
sudo composer-cli compose list
  1. Download the image
sudo composer-cli compose image <UUID OF THE COMPOSE>

@ondrejbudai ondrejbudai closed this Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP+test Work in progress but run Gitlab CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants