Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QCOW2 image generation and output test #37

Merged
merged 1 commit into from
Oct 22, 2019
Merged

QCOW2 image generation and output test #37

merged 1 commit into from
Oct 22, 2019

Conversation

msehnout
Copy link
Contributor

Adjust the qcow2 output to the official Fedora image and add a test for it. It uses the public blueprint.ToPipeline API.

teg
teg requested changes Oct 18, 2019
View reviewed changes
Copy link
Member

@teg teg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very promising! Just what we want. I just have some minor change requests inline.

internal/blueprint/f30_helpers.go Outdated Show resolved Hide resolved
internal/jobqueue/api_test.go Outdated Show resolved Hide resolved
internal/blueprint/blueprint_test.go Outdated Show resolved Hide resolved
internal/blueprint/blueprint_test.go Outdated Show resolved Hide resolved
@msehnout msehnout force-pushed the qcow2-output branch 4 times, most recently from fd3e398 to 013514d Compare October 22, 2019 06:58
@msehnout msehnout requested a review from teg October 22, 2019 07:45
@msehnout msehnout mentioned this pull request Oct 22, 2019
Merged
teg
teg approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@teg teg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@teg teg merged commit 96d401b into osbuild:master Oct 22, 2019
@larskarlitski larskarlitski mentioned this pull request Oct 22, 2019
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teg teg teg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@msehnout @teg