schutzbot: use -test.timeout argument #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
major
reviewed
May 12, 2020
schutzbot/test_runner_base.yml
Outdated
| stdout: | ||
| {{ async_test.stdout }} | ||
| - name: "Run {{ test.name }} test" | ||
| command: "{{ tests_path }}/{{ test.name }} -test.v -test.timeout {{ test.timeout * 60}}s" |
There was a problem hiding this comment.
Need a little bit of whitespace after the 60, like {{ test.timeout * 60 }}
major
reviewed
May 12, 2020
schutzbot/test_runner_image.yml
Outdated
| # upset and nobody likes it when that happens. | ||
| - name: "Run image tests" | ||
| command: | | ||
| {{ image_test_executable }} -test.v -test.timeout {{image_test_timeout * 60}}s \ |
There was a problem hiding this comment.
Need a little bit of whitespace after the 60, like {{ test.timeout * 60 }}
Use golang's `test.timeout` to set the timeout instead of using ansible's `async` property. The latter doesn't respect `register` when running into a timeout, which means there are no logs in that case.
larskarlitski
force-pushed
the
ansible-timeouts
branch
from
5044160
to
a14526f
Compare
|
Update to keep using
Oops. Fixed. |
major
approved these changes
May 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use golang's
test.timeoutto set the timeout instead of usingansible's
asyncproperty. The latter doesn't respectregisterwhenrunning into a timeout, which means there are no logs in that case.
Simplify these playbooks by setting
ignore_errors: trueon thecommandmodule, so that it's easier to collect logs.