Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSL conf stage #1278

Merged
merged 2 commits into from Apr 11, 2023
Merged

WSL conf stage #1278

merged 2 commits into from Apr 11, 2023

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Apr 4, 2023

Adds a stage to configure wsl: https://learn.microsoft.com/en-us/windows/wsl/wsl-config.

Currently only boot.systemd is added, but in future more options can of course be added.

@github-advanced-security
Copy link

You have successfully added a new shellcheck configuration differential-shellcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@croissanne croissanne changed the title Wsl stage WSL conf stage Apr 4, 2023
@croissanne croissanne marked this pull request as ready for review April 5, 2023 09:00
@croissanne croissanne marked this pull request as draft April 5, 2023 10:16
@croissanne croissanne force-pushed the wsl-stage branch 2 times, most recently from 5a7d066 to 6967fa1 Compare April 5, 2023 13:35
@croissanne croissanne marked this pull request as ready for review April 5, 2023 20:15
@croissanne croissanne requested review from thozza and supakeen and removed request for thozza April 5, 2023 20:28
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple stage 🙂 I added just a few nitpicks in the schema and unit test, otherwise all looks good 👍

Also a short PR description would be appreciated 😇

stages/org.osbuild.wsl.conf Show resolved Hide resolved
stages/org.osbuild.wsl.conf Show resolved Hide resolved
stages/org.osbuild.wsl.conf Show resolved Hide resolved
test/data/stages/wsl.conf/a.mpp.json Outdated Show resolved Hide resolved
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thozza thozza merged commit 33597e8 into osbuild:main Apr 11, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants