Python 3.6 compatibility fixes #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `capture_output` argument does not exist on Python 3.6 used by default on RHEL-8. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
|
Ack, but the README needs to be updated separately if we run on 3.6. |
supakeen
previously approved these changes
Apr 25, 2023
supakeen
previously approved these changes
Apr 25, 2023
|
Thank you :) |
achilleas-k
previously approved these changes
Apr 25, 2023
|
I found more py36 related stuff, so will back off with this PR and add those... Sorry for the noise... |
auto-merge was automatically disabled
April 25, 2023 13:02
Pull request was converted to draft
The `directory` argument has been added only since Python 3.7, which breaks the unit test on Python 3.6. Reimplement the intended behavior by overriding the `translate_path()` method, which takes the `directory` value into account on newer Python versions. Signed-off-by: Tomáš Hozza <thozza@redhat.com>
Signed-off-by: Tomáš Hozza <thozza@redhat.com>
thozza
changed the title
capture_output=True with subprocess.run()
supakeen
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
directoryargument with SimpleHTTPRequestHandler constructorcapture_output=Truewithsubprocess.run()#1262 adds testing on Python 3.6