Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

org.osbuild.mkfs.ext4: Add verity option to #1310

Merged
merged 1 commit into from
May 15, 2023

Conversation

alexlarsson
Copy link
Collaborator

This allows enabling the ext4 "verity" feature (which is currently default to off). This will be needed in the automotive work we're doing.

This allows enabling the ext4 "verity" feature (which is currently
default to off). This will be needed in the automotive work we're
doing.

Signed-off-by: Alexander Larsson <alexl@redhat.com>
@supakeen
Copy link
Member

I'd like it if the non-supplied case (with an explicit is None check) would default to not passing any arguments so it makes the same commandline as previously.

@alexlarsson
Copy link
Collaborator Author

I'd like it if the non-supplied case (with an explicit is None check) would default to not passing any arguments so it makes the same commandline as previously.

This is what the code does though?

@supakeen
Copy link
Member

supakeen commented May 15, 2023

Right, misread.

Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alexlarsson
Copy link
Collaborator Author

Do i merge it myself when i have the acks?

@ondrejbudai ondrejbudai enabled auto-merge (rebase) May 15, 2023 11:26
@ondrejbudai
Copy link
Member

Does auto-merge work for you? :)

@ondrejbudai ondrejbudai merged commit 3343696 into osbuild:main May 15, 2023
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants