stages(mkfs.ext4): add basic unit test #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcl
reviewed
Dec 13, 2023
| assert expected_err in err_msgs[0] | ||
|
|
||
|
|
||
| @pytest.mark.skipif(not has_executable("mkfs.ext4"), reason="need mkfs.ext4") |
There was a problem hiding this comment.
Nitpick alert :) We should probably standardize on the wording for missing executables in these tests. Right now we have 4 different ways to say it. I'm partial to the form I used no mkfs.ext4 executable of course, but I'm more a fan of consistency.
There was a problem hiding this comment.
Thank you! I like this attention to detail and agree. I have no strong opinion here, I will follow your lead here and use no {name} executable - at least I will try to remember, please call me out if I forget :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually meant to be the starting point of a branch that adds options to control the new
orphan_filefeature of ext4 so that we can fix osbuild/bootc-image-builder#20 by selectively enable/disable this feature based on the distro.However we decided to go into a different direction here but given that the test is already written and useful in itself I decided to open it.