-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stage/systemd-unit-create: parametrize file location #1620
Conversation
6cebe42
to
a2f533c
Compare
a2f533c
to
b40062a
Compare
b40062a
to
cbd4f17
Compare
cbd4f17
to
a3014ae
Compare
User can now customize the systemd unit load path. User can select between etc or usr , defaults to 'usr'. Also user can customize the scope of the service between global or system, defaults to system. Signed-off-by: Sayan Paul <paul.sayan@gmail.com>
a3014ae
to
c560a7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with the contents now, perhaps you could address @mvo5's concern on the description.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this is fine. I would love to see the test extended for this, I added a simple sketch of what I have in mind. But I can also push here directly or create a followup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for all the work.
User can now customize the file location of the system units. This will help user in choosing if the unit file will persist after any upgrade, defaults to false.Also user customize the scope of the service between global or system, defaults to system.