Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stage/systemd-unit-create: parametrize file location #1620

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

say-paul
Copy link
Member

@say-paul say-paul commented Mar 1, 2024

User can now customize the file location of the system units. This will help user in choosing if the unit file will persist after any upgrade, defaults to false.Also user customize the scope of the service between global or system, defaults to system.

@say-paul say-paul force-pushed the systemd-unit-stage-in-etc branch 2 times, most recently from 6cebe42 to a2f533c Compare March 1, 2024 13:14
stages/org.osbuild.systemd.unit.create Outdated Show resolved Hide resolved
@supakeen supakeen changed the title stage/systemd-unit-create:paremeterize file location stage/systemd-unit-create: parametrize file location Mar 6, 2024
@say-paul say-paul dismissed achilleas-k’s stale review March 6, 2024 10:13

updated to string from boolean

User can now customize the systemd unit load path.
User can select between etc or usr , defaults to 'usr'.
Also user can customize the scope of the service between global
or system, defaults to system.

Signed-off-by: Sayan Paul <paul.sayan@gmail.com>
Copy link
Member

@supakeen supakeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with the contents now, perhaps you could address @mvo5's concern on the description.

Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is fine. I would love to see the test extended for this, I added a simple sketch of what I have in mind. But I can also push here directly or create a followup.

0001-test-add-unit-type-path-test-coverage.patch.txt

Copy link
Member

@achilleas-k achilleas-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for all the work.

@achilleas-k achilleas-k merged commit 2d2cdd8 into osbuild:main Mar 7, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants