Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Add unit tests for org.osbuild.mkfs.btrfs stage #1681

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

elkoniu
Copy link
Contributor

@elkoniu elkoniu commented Mar 21, 2024

Add unit tests for mkfs.btrfs stage

supakeen
supakeen previously approved these changes Mar 27, 2024
@supakeen
Copy link
Member

supakeen commented Mar 27, 2024

Since it's a common pattern I'll point it out here: I'm fine with using re.search for substrings :)

Needs linter appeasement.

Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks good just tiny tiny suggestion about a redundant open/truncate inline.

stages/test/test_mkfs_btrfs.py Outdated Show resolved Hide resolved
@elkoniu elkoniu force-pushed the org.osbuild.mkfs.btrfs-unit-tests branch from b648f63 to 646b6c5 Compare April 2, 2024 10:30
mvo5
mvo5 previously approved these changes Apr 2, 2024
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

supakeen
supakeen previously approved these changes Apr 3, 2024
@supakeen
Copy link
Member

supakeen commented Apr 3, 2024

Still needs the re import removed.

@elkoniu elkoniu dismissed stale reviews from supakeen and mvo5 via 813e36d April 3, 2024 14:53
@elkoniu elkoniu force-pushed the org.osbuild.mkfs.btrfs-unit-tests branch from 646b6c5 to 813e36d Compare April 3, 2024 14:53
@elkoniu elkoniu force-pushed the org.osbuild.mkfs.btrfs-unit-tests branch from 813e36d to 42da28d Compare April 3, 2024 20:14
@bcl bcl force-pushed the org.osbuild.mkfs.btrfs-unit-tests branch from 42da28d to 6dd8472 Compare April 8, 2024 23:29
@bcl bcl enabled auto-merge (rebase) April 8, 2024 23:29
@bcl bcl merged commit 488eee7 into osbuild:main Apr 9, 2024
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants