-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: Add unit tests for org.osbuild.gunzip stage #1689
base: main
Are you sure you want to change the base?
Conversation
25a93e2
to
160c8c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! A quick first look with some ideas/suggestions
160c8c1
to
f25e9b9
Compare
@mvo5 thanks for the review, I have applied some changes to the code.
I mean - how to include |
f25e9b9
to
11cd7dd
Compare
11cd7dd
to
6797e7b
Compare
The here here seems to be from "test_file.txt.gz" vs "fake_file.txt.gz" not from the stdout? |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
@elkoniu Hey, this got the "stale" label now, but all it needs to get merged is a tiny fix in the unit tests (see previous comment). would you mind fixing it so that this can get in? |
bf11787
to
97ff022
Compare
@mvo5 thanks for pointing this out, I have just updated the test case so it will not fail anymore :) |
030606c
to
3de4929
Compare
3de4929
to
53db168
Compare
autopep8 is still unhappy: https://github.com/osbuild/osbuild/actions/runs/9061539700/job/24893504856?pr=1689#step:3:366 |
This PR is stale because it has been open 30 days with no activity. Remove "Stale" label or comment or this will be closed in 7 days. |
This PR adds unit tests for org.osbuild.gunzip stage.