Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stages: ensure we do not allow \n in the ssh key or anaconda breaks #1772

Closed
wants to merge 1 commit into from
Closed

stages: ensure we do not allow \n in the ssh key or anaconda breaks #1772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions stages/org.osbuild.kickstart.meta.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@
},
"key": {
"description": "SSH Public Key to add to ~/.ssh/authorized_keys",
"pattern": "^[^\\n]*$",
"type": "string"
}
}
Expand Down
3 changes: 3 additions & 0 deletions stages/test/test_kickstart.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,9 @@ def test_kickstart_valid(tmp_path, stage_module, test_input, expected): # pylin
{"rootpw": {"iscrypted": True, "plaintext": True, "password": "pass"}},
"is not valid under any of the given schemas"
),
# TODO: test with only \n at the end
({"users": {"test": {"key": "a-ssh-key-with-wrong\nnewlines\n"}}},
"does not match '^[^\\\\n]*$'"),
],
)
@pytest.mark.parametrize("stage_schema", ["1"], indirect=True)
Expand Down
Loading