stages/ostree.preptree: fix machine-id detection #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do the check if there is a /etc/machine-id before moving /etc to /usr/etc, because otherwise /etc/machine-id will obviously not exist and thus the detection is broken.
gicmo
added
the
bug
teg
approved these changes
Mar 2, 2021
achilleas-k
approved these changes
Mar 2, 2021
2 tasks
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 3, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 4, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 11, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 12, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 12, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 15, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 15, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
achilleas-k
added a commit
to achilleas-k/osbuild-composer
that referenced
this pull request
Mar 16, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
teg
pushed a commit
to osbuild/osbuild-composer
that referenced
this pull request
Mar 17, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600
ondrejbudai
pushed a commit
to ondrejbudai/osbuild-composer
that referenced
this pull request
Mar 17, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600 (cherry picked from commit 3618611) Signed-off-by: Ondřej Budai <ondrej@budai.cz>
ondrejbudai
pushed a commit
to osbuild/osbuild-composer
that referenced
this pull request
Mar 17, 2021
We need to test the PR before a new osbuild is released. Pinning to current `main`. In particular, we need to test against osbuild/osbuild#600 (cherry picked from commit 3618611) Signed-off-by: Ondřej Budai <ondrej@budai.cz>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the check if there is a
/etc/machine-idbefore moving/etcto/usr/etc, because otherwise/etc/machine-idwill obviously not exist and thus the detection is broken.