stages/grub2: ability to not write kernel cmdline
#939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also check that the schema is valid for devices and mounts.
The uuid schema is duplicated in a few places. Extract it and use references to it instead.
For you, David.
Currently we always write the kernel command line to the `grubenv`
file, if only to include the root device. Starting with Fedora 33
and thus RHEL 9, the kernel command line included statically in
the BLS snippets and the grubenv `kernelopts` variable not used.
Instead one of the {/usr/lib,/etc}/kernel/cmdline files is read
and the parameters in them used during the creation of the BLS
snippets.
Therefore we add a new `write_cmdline` option that, if set to
FALSE, will prevent us from writing the kernel command line.
In the fedora-boot manifest, do not write the kernel command line to the `grubenv` file.
teg
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we always write the kernel command line to the
grubenvfile, if only to include the root device. Starting with Fedora 33 and thus RHEL 9, the kernel command line included statically in the BLS snippets and the grubenvkerneloptsvariable not used. Instead one of the {/usr/lib,/etc}/kernel/cmdline files is read and the parameters in them used during the creation of the BLS snippets.Therefore we add a new
write_cmdlineoption that, if set to FALSE, will prevent us from writing the kernel command line.