Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch legacy grub compatibility #941

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Conversation

jelly
Copy link
Collaborator

@jelly jelly commented Jan 3, 2022

This is the final piece for generating a successful booting Arch Linux VM. Arch Linux can't use the normal grub stage as the the open bootloader specification patches are not merged upstream yet.

@gicmo
Copy link
Contributor

gicmo commented Jan 4, 2022

@jelly I wonder if we need bootpath. We have logic to determine the grub home (the path that contains the grub2 directory): in the org.osbuild.grub2 stage it is via the rootfs and bootfs options, i.e. if they are specified and different then grub is on a separate boot partition and thus the prefix is /, otherwise it is /boot. I think the same logic could be applied for the org.osbuild.grub2.legacy stage. and thus you could just use GrubConfig.grub_home instead of the new bootpath config option. The variable for the template is called root in the grub2 stage:

search --no-floppy --set prefix --file ${root}grub2/grub.cfg

@jelly
Copy link
Collaborator Author

jelly commented Jan 4, 2022

That sounds like a much better solution!

Additionally add a new QEMU image output target for testing
grub2/mkinitcpio stages.
Installing the mkinitcpio kernel preset's requires /dev/stdin to be
available for calling install.
Copy link
Contributor

@gicmo gicmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gicmo gicmo merged commit e3515ca into osbuild:main Jan 6, 2022
@jelly jelly deleted the arch_legacy_boot branch January 6, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants