stages/sfdisk: support changing GPT partition attribute bits #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eballetbo
force-pushed
the
attrs-for-gpt-parts
branch
from
06a8ace
to
41a3ba5
Compare
teg
requested changes
Feb 10, 2022
There was a problem hiding this comment.
Hi @eballetbo! Thanks for your contribution. It looks reasonable to me, I only have one style comment.
When is specified change the GPT partition attribute bits. The attributes is a comma list of bits numbers or bit names. You can take a look at the manual page of sfdisk to see the supported attribute bits.
eballetbo
force-pushed
the
attrs-for-gpt-parts
branch
from
41a3ba5
to
ee9f1a4
Compare
|
Pushed a new branch with the requested changes. Using an array of integers and removed the debug message introduced by mistake. |
|
Restarted the test. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GPT attribute field is a 64-bit field that contains two subfields. The higher field is interpreted only in the context of the partition ID, while the lower field is common to all partition IDs. sfdisk supports to change this fields, and also a osbuild user might be interested on change these bits. This patchset adds support to change these bits in the sfdisk stage.
The meaning of these bits (from Wikipedia) :