Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs/build gen oscal instructions for gen_oscal and fix_any added to website.md #389

Merged
merged 3 commits into from Mar 7, 2021

Conversation

fsuits
Copy link
Collaborator

@fsuits fsuits commented Mar 5, 2021

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • All commits are signed-off.

Added instructions for developers on how to generate the oscal models from json.

@fsuits fsuits requested review from degenaro and butler54 March 5, 2021 04:02
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #389 (3157ae2) into develop (fcbaa23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #389   +/-   ##
========================================
  Coverage    98.99%   98.99%           
========================================
  Files           58       58           
  Lines         7066     7066           
========================================
  Hits          6995     6995           
  Misses          71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcbaa23...3157ae2. Read the comment docs.

Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 merged commit 5053e52 into develop Mar 7, 2021
@butler54 butler54 deleted the docs/build_gen_oscal branch March 7, 2021 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants