Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move IO out of Ungoliant #83

Merged
merged 4 commits into from Jan 20, 2023
Merged

Move IO out of Ungoliant #83

merged 4 commits into from Jan 20, 2023

Conversation

Uinelj
Copy link
Member

@Uinelj Uinelj commented Jan 20, 2023

Rely more on oscar-io to handle type definitions and Readers/Writers.

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #83 (a006079) into dev (9bf4dcb) will decrease coverage by 2.12%.
The diff coverage is 46.15%.

❗ Current head a006079 differs from pull request most recent head e5d21d9. Consider uploading reports for the commit e5d21d9 to get more accurate results

@@            Coverage Diff             @@
##              dev      #83      +/-   ##
==========================================
- Coverage   45.64%   43.53%   -2.12%     
==========================================
  Files          27       26       -1     
  Lines        1310     1245      -65     
==========================================
- Hits          598      542      -56     
+ Misses        712      703       -9     
Impacted Files Coverage Δ
src/identifiers/multilingual.rs 59.59% <ø> (ø)
src/io/langfiles.rs 69.23% <ø> (ø)
src/io/writer/writer_doc.rs 71.42% <ø> (ø)
src/pipelines/oscardoc/pipeline.rs 0.00% <0.00%> (ø)
src/processing/rebuild.rs 0.00% <ø> (ø)
src/transformers/content_detector.rs 100.00% <ø> (ø)
src/identifiers/identification.rs 75.00% <66.66%> (+19.44%) ⬆️
src/pipelines/oscardoc/types/document.rs

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Uinelj Uinelj merged commit 5368804 into dev Jan 20, 2023
@Uinelj Uinelj deleted the dev-move-io branch January 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant