Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some startup errors #56

Closed
wants to merge 3 commits into from

Conversation

thirumoorthir
Copy link
Contributor

@thirumoorthir thirumoorthir commented Apr 27, 2018

Hi There,

These are the errors i faced while using oscar, I fixed those errors, Please accept my Pull request

Thanks
Thiru

Copy link
Member

@Sharpie Sharpie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just had one note about ignoring all .DS_Store files.

@@ -1,3 +1,6 @@
.vagrant
config.yaml
.pe_build
*.gem
templates/oscar-init-skeleton/.DS_Store
.DS_Store
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two entries for .DS_Store could be replaced with:

**/.DS_Store

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @Sharpie updated as you suggested and submitted new #57

@Sharpie
Copy link
Member

Sharpie commented Jul 24, 2018

Closing in favor of #57.

@Sharpie Sharpie closed this Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants