(feat) Add vagrant-bolt as a gem dependency #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tested this with vagrant 1.8.7. The result is that it does not break the configuration as the plugin does not get loaded. |
Sharpie
requested changes
Aug 23, 2019
lib/oscar.rb
Outdated
| @@ -3,6 +3,7 @@ module Oscar | |||
| require 'vagrant-pe_build' | |||
| require 'vagrant-auto_network' | |||
| require 'vagrant-config_builder' | |||
| require 'vagrant-bolt' unless Vagrant::VERSION < "2.2.0" | |||
There was a problem hiding this comment.
String comparison can be a bit tricksy for version numbers. I'd use the following:
require 'rubygems/requirement'
Gem::Requirement.new('>= 2.2.0').satisfied_by?(Gem::Version.new(Vagrant::VERSION))
There was a problem hiding this comment.
Ah good to know. Thanks for the code. I pushed an update with this comparison.
This commit adds a new dependency to this module: vagrant-bolt. This new dependency will install the `vagrant-bolt` plugin and load it if the vagrant version is higer than 2.2.
|
Shipped Oscar 0.6.0, which includes this dependency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new dependency to this module: vagrant-bolt. This
new dependency will install the
vagrant-boltplugin and load it ifthe vagrant version is higher than 2.2.