Feature/master/windows #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides support for running Windows batch provisioning files
Need to allow specifying things like guest, etc.
OS-dependent control flow added around provisioning and configuring nodes
Add pre-provisioning and pe-installation logic to handle Windows nodes. TODO: reboot windows node as final step of provisioning (for rename)
| @@ -0,0 +1,4 @@ | |||
There was a problem hiding this comment.
This is seriously awesome work, and I think it would be great to have that in core vagrant.
There was a problem hiding this comment.
I can't claim any credit for this, it's just copy-pasta from the core shell provisioner with some minor modifications to make it compatible with windows. Very much an "it needs to work now" hack. I imagine someone could obtain the functionality by extending the built-in shell provisioner...
|
@reidmv so... did we actually solve this? |
|
Heh; we must have solved it somewhere along the way. Seems like this is now the domain of vagrant-hosts, not oscar. :-) |
|
Woo! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for Windows VMs. The code is messy but functional. Rather than merging it directly it might be a better idea to restructure it.
Pros:
Cons:
Opening the pull request now so the code can be reviewed but the more I think about it the more it feels like this isn't ready to merge. Here's a pull request! :)