Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added check if GAP is initialized to run_it #130

Merged
merged 2 commits into from
Nov 5, 2018

Conversation

sebasguts
Copy link
Contributor

@sebasguts sebasguts commented Nov 5, 2018

Resolves #113

@codecov
Copy link

codecov bot commented Nov 5, 2018

Codecov Report

Merging #130 into master will increase coverage by 0.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #130      +/-   ##
==========================================
+ Coverage   54.31%   54.33%   +0.01%     
==========================================
  Files          44       44              
  Lines        2629     2632       +3     
==========================================
+ Hits         1428     1430       +2     
- Misses       1201     1202       +1
Impacted Files Coverage Δ
LibGAP.jl/src/initialization.jl 88.46% <75%> (-2.85%) ⬇️

fingolfin
fingolfin previously approved these changes Nov 5, 2018
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK, but I made one minor change suggestion

LibGAP.jl/src/initialization.jl Outdated Show resolved Hide resolved
Co-Authored-By: sebasguts <gutsche@mathematik.uni-siegen.de>
@sebasguts sebasguts dismissed stale reviews from fingolfin via ea5ec3e November 5, 2018 15:28
@sebasguts sebasguts merged commit fd01ea5 into oscar-system:master Nov 5, 2018
@sebasguts sebasguts deleted the run_it_error_check branch November 14, 2018 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants