Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete GAP.GAPFuncs #256

Merged
merged 1 commit into from Jun 17, 2019

Conversation

fingolfin
Copy link
Member

Use GAP.Globals instead.

CC @CarloSircana

@fingolfin fingolfin requested a review from sebasguts June 16, 2019 21:25
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #256 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   69.95%   69.94%   -0.01%     
==========================================
  Files          49       49              
  Lines        3258     3257       -1     
==========================================
- Hits         2279     2278       -1     
  Misses        979      979
Impacted Files Coverage Δ
pkg/GAPJulia/JuliaInterface/julia/ccalls.jl 93.44% <ø> (ø) ⬆️
...PJulia/JuliaInterface/example/gap_function_call.jl 0% <0%> (ø) ⬆️
pkg/GAPJulia/JuliaInterface/julia/gap.jl 47.05% <0%> (-1.02%) ⬇️

Use GAP.Globals instead
@fingolfin fingolfin merged commit fb8c01f into oscar-system:master Jun 17, 2019
@fingolfin fingolfin deleted the mh/remove-GAPFuncs branch June 17, 2019 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants