Fix GAP.Packages.install with a HACK #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #413 +/- ##
==========================================
+ Coverage 73.29% 73.52% +0.22%
==========================================
Files 66 67 +1
Lines 5101 5099 -2
==========================================
+ Hits 3739 3749 +10
+ Misses 1362 1350 -12
|
fingolfin
force-pushed
the
mh/fix-Packages.install
branch
3 times, most recently
from
4049e2d
to
31d0c4d
Compare
fingolfin
changed the title
fingolfin
changed the title
fingolfin
force-pushed
the
mh/fix-Packages.install
branch
from
31d0c4d
to
698d7b5
Compare
|
The following failed: julia> GAP.Packages.install("io")
#I Getting PackageInfo URLs...
#I Created directory /Users/mo/.julia/dev/GAP/deps/build/gap-4.11.0-julia-1.4.0/pkg/
#I Retrieving PackageInfo.g from https://gap-packages.github.io/io/PackageInfo.g ...
#I Downloading archive from URL https://github.com/gap-packages/io/releases/download/v4.7.0/io-4.7.0.tar.gz ...
#I Saved archive to /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmJRWQuN/io-4.7.0.tar.gz
#I Extracting to /Users/mo/.julia/dev/GAP/deps/build/gap-4.11.0-julia-1.4.0/pkg/io-4.7.0 ...
#I Running compilation script on /Users/mo/.julia/dev/GAP/deps/build/gap-4.11.0-julia-1.4.0/pkg/io-4.7.0 ...
#I Possible error detected: see log at /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmpS3y8c/exec-log.txt
#I Compilation failed (package may still be usable)
#I Package availability test failed
#I (for IO 4.7.0)
#I Removed directory /Users/mo/.julia/dev/GAP/deps/build/gap-4.11.0-julia-1.4.0/pkg/io-4.7.0
false |
fingolfin
force-pushed
the
mh/fix-Packages.install
branch
from
698d7b5
to
48e088f
Compare
fingolfin
force-pushed
the
mh/fix-Packages.install
branch
4 times, most recently
from
b58e182
to
b2d7a43
Compare
|
Thank you for supporting the optional argument |
This was referenced May 12, 2020
We manipulate some internal state of the GAP PackageManager to make it use our custom copy of BuildPackage.sh. This should be dropped once there is a newer PackageManager version.
fingolfin
force-pushed
the
mh/fix-Packages.install
branch
from
b2d7a43
to
d954c9b
Compare
|
@mohamed-barakat tests for this finally pass. Perhaps you can to try it again? |
For CI, instead invoke GAP.Packages.install
|
Compiling julia> GAP.Packages.install("io")
#I Getting PackageInfo URLs...
#I Retrieving PackageInfo.g from https://gap-packages.github.io/io/PackageInfo.g ...
#I Downloading archive from URL https://github.com/gap-packages/io/releases/download/v4.7.0/io-4.7.0.tar.gz ...
#I Saved archive to /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmuuTeUm/io-4.7.0.tar.gz
#I Extracting to /Users/mo/.gap/pkg/io-4.7.0 ...
true
julia> GAP.Packages.install("io")
#I Getting PackageInfo URLs...
#I Retrieving PackageInfo.g from https://gap-packages.github.io/io/PackageInfo.g ...
#I The newest version of package "io" is already installed
true
julia> GAP.Packages.install("digraphs")
#I Getting PackageInfo URLs...
#I Retrieving PackageInfo.g from https://gap-packages.github.io/Digraphs/PackageInfo.g ...
#I Downloading archive from URL https://github.com/gap-packages/Digraphs/releases/download/v1.2.0/digraphs-1.2.0.tar.gz ...
#I Saved archive to /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmZNitPP/digraphs-1.2.0.tar.gz
#I Extracting to /Users/mo/.gap/pkg/digraphs-1.2.0 ...
#I Checking dependencies for Digraphs...
#I io >=4.5.1: true
#I orb >=4.8.2: true
#I datastructures >=0.2.5: false
#I Retrieving PackageInfo.g from https://gap-packages.github.io/datastructures/PackageInfo.g ...
#I Installing dependency datastructures 0.2.5 ...
#I Downloading archive from URL https://github.com/gap-packages/datastructures/releases/download/v0.2.5/datastructures-0.2.5.tar.gz ...
#I Saved archive to /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmBbHLyj/datastructures-0.2.5.tar.gz
#I Extracting to /Users/mo/.gap/pkg/datastructures-0.2.5 ...
#I Checking dependencies for datastructures...
#I GAPDoc 1.5: true
#I Running compilation script on /Users/mo/.gap/pkg/datastructures-0.2.5 ...
#I Possible error detected: see log at /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmZMOECA/exec-log.txt
#I Compilation failed (package may still be usable)
#I Checking dependencies for datastructures...
#I GAPDoc 1.5: true
#I Package availability test failed
#I (for datastructures 0.2.5)
#I Removed directory /Users/mo/.gap/pkg/datastructures-0.2.5
#I Dependencies not satisfied for digraphs-1.2.0
#I Removed directory /Users/mo/.gap/pkg/digraphs-1.2.0
false |
|
So what does the log at /var/folders/z7/br6dwhjj5xn8691ygcnbzxc40000gs/T//tmZMOECA/exec-log.txt say? |
|
Dump of |
|
That's odd: the given path is into the artifact and indeed not the correct GAPROOT. But the main point of this PR is to solve this kind of problem, by (a) using a newer version of I tried replicating this, but failed. In particular, it works fine on my Mac, on plesken and in a ubuntu docker container (which I just had running for your issue #465 anyway). @mohamed-barakat Could you please provide some details about the system where the issue appears? |
|
@mohamed-barakat I am going to merge this anyway, as it seems to improve lots of things and doesn't make anything worse. If you can still reproduce the digraphs problems afterwards, please open an issue for it (with some details on the system where it occurs), then I can work on fixing it in a new PR. |
|
I was probably doing something wrong. It is now working. |
|
Now that |
mohamed-barakat
added a commit
to mohamed-barakat/HomalgProject.jl
that referenced
this pull request
May 20, 2020
Now that oscar-system/GAP.jl#413 has been merged start using `GAP.Packages.install`. Closes homalg-project#22
mohamed-barakat
added a commit
to mohamed-barakat/HomalgProject.jl
that referenced
this pull request
May 20, 2020
Now that oscar-system/GAP.jl#413 has been merged start using `GAP.Packages.install`. Closes homalg-project#22
|
@mohamed-barakat: done, GAP.jl 0.4.1 is tagged and should be available soon |
|
Wonderful, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #452
Closes #467