Two fixes for setup.jl #593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids potential issues with all kinds of junk in those startup files.
This should make them more robust when a user has multiple Julia versions installed in parallel by creating symlinks like `julia-1.5` pointing to the actual Julia executables.
Codecov Report
@@ Coverage Diff @@
## master #593 +/- ##
=======================================
Coverage 77.16% 77.16%
=======================================
Files 45 45
Lines 3766 3766
=======================================
Hits 2906 2906
Misses 860 860
|
The upgrade to 0.11 (and/or to Nemo 0.18.5) breaks some of our tests as printing changes. Since the new printing is IMHO worse, we should investigate this further; in the meantime, fix the CI tests by restricting the AbstractAlgebra version.
fingolfin
force-pushed
the
mh/fix-setup
branch
from
0ff7748
to
349df20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.