This repository has been archived by the owner on Jul 1, 2022. It is now read-only.
Add doctests, import JConvex #70
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
==========================================
+ Coverage 86.10% 86.14% +0.04%
==========================================
Files 5 5
Lines 295 296 +1
==========================================
+ Hits 254 255 +1
Misses 41 41
Continue to review full report at Codecov.
|
fingolfin
force-pushed
the
mh/import-JConvex
branch
from
513be52
to
0dc6b0b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes PR #62 (adds doctest, resolves #46, closes #62) but also imports JConvex (resolves #64).
However, I took the lazy approach and just copied the JConvex files. If you prefer to include the history, you could do so in your own PR and just cherry-pick the last commit in this PR.