fixed f_vector(::Polyhedron) for non-trivial lineality space and adde…

…d test; removed outdated comment
oscar-system · Sep 30, 2021 · 0af6d7c · 0af6d7c
1 parent 634fc76
commit 0af6d7c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/src/Polytopes/Polyhedron/properties.jl b/src/Polytopes/Polyhedron/properties.jl
@@ -480,14 +480,6 @@ julia> lineality_space(UH)
 """
 lineality_space(P::Polyhedron) = VectorIterator{RayVector{Polymake.Rational}}(dehomogenize(P.pm_polytope.LINEALITY_SPACE))
 
-# function affine_hull(P::Polyhedron)
-#     a = P.pm_polytope.AFFINE_HULL
-#     x = -a[:, 1]
-#     y = a[:, 2:end]
-#     v = sum((x[i] * y[i, :] for i in 1:length(x)))
-#     return (PointVector(v), VectorIterator{RayVector{Polymake.Rational}}(y))
-# end
-
 @doc Markdown.doc"""
     affine_hull(P::Polytope)
 
@@ -666,7 +658,8 @@ julia> f_vector(cube(5))
 ```
 """
 function f_vector(P::Polyhedron)
-    f_vec=[length(collect(faces(P,i))) for i in 0:dim(P)-1]
+    ldim = lineality_dim(P)
+    f_vec=vcat(zeros(Int64, ldim), [length(faces(P,i)) for i in ldim:dim(P)-1])
     return f_vec
 end
 

diff --git a/test/Polytopes/Polyhedron.jl b/test/Polytopes/Polyhedron.jl
@@ -31,6 +31,7 @@
         @test intersect(Q0, Q0) == Q0
         @test Q0+Q0 == minkowski_sum(Q0, Q0)
         @test f_vector(Pos) == [1,3,3]
+        @test f_vector(L) == [0, 1, 2]
         @test codim(square) == 0
         @test codim(point) == 3
         @test !isfulldimensional(point)