Show method of toric divisor shows details of the toric ambient space

docs/src/ToricVarieties/ToricDivisors.md

@@ -43,4 +43,5 @@ isvery_ample(td::ToricDivisor)
 ```@docs
 coefficients(td::ToricDivisor)
 polyhedron(td::ToricDivisor)
+toricvariety(td::ToricDivisor)
 ```

src/ToricVarieties/ToricDivisors/attributes.jl

@@ -75,3 +75,14 @@ function coefficients(td::ToricDivisor)
     return td.attributes[coefficients]
 end
 export coefficients
+
+
+@doc Markdown.doc"""
+    toricvariety(td::ToricDivisor)
+
+Return the toric variety of a torus invariant Weil divisor.
+"""
+function toricvariety(td::ToricDivisor)
+    return td.attributes[toricvariety]
+end
+export toricvariety

src/ToricVarieties/ToricDivisors/auxilliary.jl

@@ -95,7 +95,7 @@ function output_string(td::ToricDivisor)
     if last(out_string) == ','
         out_string = chop(out_string)
     end
-    out_string = out_string * "divisor on a normal toric variety";
+    out_string = out_string * "divisor on a" * chop(output_string(toricvariety(td)), head = 1, tail = 0)
 
     # return result
     return out_string

src/ToricVarieties/ToricDivisors/constructors.jl

@@ -25,8 +25,8 @@ Construct the torus invariant divisor on the normal toric variety `v` as linear
 
 # Examples
 ```jldoctest
-julia> show(ToricDivisor(toric_projective_space(2), [1,1,2]))
-A torus invariant divisor on a normal toric variety
+julia> ToricDivisor(toric_projective_space(2), [1,1,2])
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 ```
 """
 function ToricDivisor(v::AbstractNormalToricVariety, coeffs::Vector{Int})
@@ -36,7 +36,7 @@ function ToricDivisor(v::AbstractNormalToricVariety, coeffs::Vector{Int})
     pmntv = pm_object(v)
     ptd = Polymake.fulton.TDivisor(COEFFICIENTS=coeffs)
     Polymake.add(pmntv, "DIVISOR", ptd)
-    attributes = Dict(coefficients=>coeffs)
+    attributes = Dict(coefficients=>coeffs, toricvariety=>v)
     return ToricDivisor(ptd, Dict{Any,Bool}(), attributes)
 end
 export ToricDivisor
@@ -53,8 +53,8 @@ Construct the torus invariant divisor associated to a character of the normal to
 
 # Examples
 ```jldoctest
-julia> show(DivisorOfCharacter(toric_projective_space(2), [1,2]))
-A torus invariant divisor on a normal toric variety
+julia> DivisorOfCharacter(toric_projective_space(2), [1,2])
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 ```
 """
 function DivisorOfCharacter(v::AbstractNormalToricVariety, character::Vector{Int})

src/ToricVarieties/ToricDivisors/properties.jl

@@ -9,7 +9,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> iscartier(td)
 true
@@ -34,7 +34,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isprincipal(td)
 false
@@ -59,7 +59,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isbasepoint_free(td)
 true
@@ -84,7 +84,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> iseffective(td)
 true
@@ -109,7 +109,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isintegral(td)
 true
@@ -134,7 +134,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isample(td)
 false
@@ -159,7 +159,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isvery_ample(td)
 false
@@ -184,7 +184,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isnef(td)
 true
@@ -209,7 +209,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isq_cartier(td)
 true
@@ -235,7 +235,7 @@ julia> H = hirzebruch_surface(4)
 A normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> td = ToricDivisor(H, [1,0,0,0])
-A torus invariant divisor on a normal toric variety
+A torus invariant divisor on a normal non-affine, smooth, projective, gorenstein, q-gorenstein, non-fano toric variety without torusfactor corresponding to a polyhedral fan in ambient dimension 2
 
 julia> isprime_divisor(td)
 true

test/ToricVarieties/runtests.jl

@@ -194,6 +194,7 @@ D=ToricDivisor(H5, [0,0,0,0])
 D2 = DivisorOfCharacter(H5, [1,2])
 
 @testset "Divisors" begin
+    @test dim(toricvariety(D)) == 2
     @test isprime_divisor(D) == false
     @test iscartier(D) == true
     @test isprincipal(D) == true