Add isfinitelygenerated(G::GAPGroup)

oscar-system · Mar 2, 2022 · c83aaa6 · c83aaa6
1 parent 9f88359
commit c83aaa6
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 0 deletions.
diff --git a/docs/src/Groups/basics.md b/docs/src/Groups/basics.md
@@ -83,6 +83,7 @@ issolvable
 isperfect
 issimple
 isalmostsimple
+isfinitelygenerated
 ```
 
 

diff --git a/src/Groups/GAPGroups.jl b/src/Groups/GAPGroups.jl
@@ -33,6 +33,7 @@ export
     isalmostsimple, hasisalmostsimple, setisalmostsimple,
     isconjugate,
     isfinite, hasisfinite, setisfinite,
+    isfinitelygenerated, hasisfinitelygenerated, setisfinitelygenerated,
     isfiniteorder,
     isperfect, hasisperfect, setisperfect,
     ispgroup,
@@ -911,6 +912,29 @@ function ispgroup(G::GAPGroup)
    return false, nothing
 end
 
+"""
+    isfinitelygenerated(G)
+
+Return whether `G` is a finitely generated group.
+
+# Examples
+```jldoctest
+julia> F = free_group(2)
+<free group on the generators [ f1, f2 ]>
+
+julia> isfinitelygenerated(F)
+true
+
+julia> H = derived_subgroup(F)[1]
+Group(<free, no generators known>)
+
+julia> isfinitelygenerated(H)
+false
+```
+"""
+@gapattribute isfinitelygenerated(G::GAPGroup) = GAP.Globals.IsFinitelyGeneratedGroup(G.X)::Bool
+
+
 @doc Markdown.doc"""
     relators(G::FPGroup)